Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2598 #2641

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Fixes #2598 #2641

merged 1 commit into from
Dec 8, 2022

Conversation

NikCharlebois
Copy link
Collaborator

Pull Request (PR) description

  • Added support for the PasswordPolicies property.

This Pull Request (PR) fixes the following issues

@NikCharlebois NikCharlebois merged commit 612bec1 into microsoft:Dev Dec 8, 2022
@NikCharlebois NikCharlebois deleted the Fixes-#2598 branch December 8, 2022 20:51
@andreasmarx
Copy link

@NikCharlebois The property 'PasswordPolicies' does not need to be exposed as a parameter, because we already have the parameter 'PasswordNeverExpires' which actually sets the property 'PasswordPolicies'. Or we remove the parameter 'PasswordNeverExpires' and expose 'PasswordPolicies'. Exposing both makes no sense from my point of view. With the current code change we would have the new parameter which is never honored. 'Set-TargetResource' would have to be modified for that.

'PasswordPolicies' would accept 'DisablePasswordExpiration', 'DisableStrongPassword' or both 'DisablePasswordExpiration, DisableStrongPassword' and should return NONE or NULL when not defined. (would have to be tested ...)
https://learn.microsoft.com/en-us/powershell/module/microsoft.graph.users/new-mguser?view=graph-powershell-1.0

For just fixing the original issue I would recommend to remove the new parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSFT_AADUser: Bug getting passwordpolicies
2 participants